Some checks failed
Self-hosted runner (nightly-past-ci-caller) / Get number (push) Has been cancelled
Self-hosted runner (nightly-past-ci-caller) / TensorFlow 2.11 (push) Has been cancelled
Self-hosted runner (nightly-past-ci-caller) / TensorFlow 2.10 (push) Has been cancelled
Self-hosted runner (nightly-past-ci-caller) / TensorFlow 2.9 (push) Has been cancelled
Self-hosted runner (nightly-past-ci-caller) / TensorFlow 2.8 (push) Has been cancelled
Self-hosted runner (nightly-past-ci-caller) / TensorFlow 2.7 (push) Has been cancelled
Self-hosted runner (nightly-past-ci-caller) / TensorFlow 2.6 (push) Has been cancelled
Self-hosted runner (nightly-past-ci-caller) / TensorFlow 2.5 (push) Has been cancelled
Self-hosted runner (benchmark) / Benchmark (aws-g5-4xlarge-cache) (push) Has been cancelled
Build documentation / build (push) Has been cancelled
Build documentation / build_other_lang (push) Has been cancelled
CodeQL Security Analysis / CodeQL Analysis (push) Has been cancelled
New model PR merged notification / Notify new model (push) Has been cancelled
PR CI / pr-ci (push) Has been cancelled
Slow tests on important models (on Push - A10) / Get all modified files (push) Has been cancelled
Secret Leaks / trufflehog (push) Has been cancelled
Update Transformers metadata / build_and_package (push) Has been cancelled
Slow tests on important models (on Push - A10) / Model CI (push) Has been cancelled
Check Tiny Models / Check tiny models (push) Has been cancelled
Self-hosted runner (Intel Gaudi3 scheduled CI caller) / Model CI (push) Has been cancelled
Self-hosted runner (Intel Gaudi3 scheduled CI caller) / Pipeline CI (push) Has been cancelled
Self-hosted runner (Intel Gaudi3 scheduled CI caller) / Example CI (push) Has been cancelled
Self-hosted runner (Intel Gaudi3 scheduled CI caller) / DeepSpeed CI (push) Has been cancelled
Self-hosted runner (Intel Gaudi3 scheduled CI caller) / Trainer/FSDP CI (push) Has been cancelled
Nvidia CI - Flash Attn / Setup (push) Has been cancelled
Nvidia CI - Flash Attn / Model CI (push) Has been cancelled
Nvidia CI / Setup (push) Has been cancelled
Nvidia CI / Model CI (push) Has been cancelled
Nvidia CI / Torch pipeline CI (push) Has been cancelled
Nvidia CI / Example CI (push) Has been cancelled
Nvidia CI / Trainer/FSDP CI (push) Has been cancelled
Nvidia CI / DeepSpeed CI (push) Has been cancelled
Nvidia CI / Quantization CI (push) Has been cancelled
Nvidia CI / Kernels CI (push) Has been cancelled
Doctests / Setup (push) Has been cancelled
Doctests / Call doctest jobs (push) Has been cancelled
Doctests / Send results to webhook (push) Has been cancelled
Extras Smoke Test / Get supported Python versions (push) Has been cancelled
Extras Smoke Test / Test extras on Python ${{ matrix.python-version }} (push) Has been cancelled
Extras Smoke Test / Check Slack token availability (push) Has been cancelled
Extras Smoke Test / Notify failures to Slack (push) Has been cancelled
Self-hosted runner (AMD scheduled CI caller) / Trigger Scheduled AMD CI (push) Has been cancelled
Stale Bot / Close Stale Issues (push) Has been cancelled
152 lines
5.1 KiB
Python
152 lines
5.1 KiB
Python
# Copyright 2026 The HuggingFace Team. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import os
|
|
import sys
|
|
import tempfile
|
|
import unittest
|
|
from contextlib import contextmanager
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
from unittest.mock import patch
|
|
|
|
|
|
git_repo_path = os.path.abspath(os.path.dirname(os.path.dirname(os.path.dirname(__file__))))
|
|
utils_path = os.path.join(git_repo_path, "utils")
|
|
if utils_path not in sys.path:
|
|
sys.path.append(utils_path)
|
|
|
|
import check_repo # noqa: E402
|
|
|
|
|
|
class RecordingNamespace:
|
|
"""Record directory listings and attribute access for cache tests."""
|
|
|
|
def __init__(self, mapping):
|
|
self._mapping = mapping
|
|
self.dir_calls = 0
|
|
self.getattr_calls = []
|
|
|
|
def __dir__(self):
|
|
self.dir_calls += 1
|
|
return list(self._mapping.keys()) + ["__doc__"]
|
|
|
|
def __getattr__(self, name):
|
|
self.getattr_calls.append(name)
|
|
try:
|
|
return self._mapping[name]
|
|
except KeyError as error:
|
|
raise AttributeError(name) from error
|
|
|
|
|
|
@contextmanager
|
|
def patch_transformers_path(path: Path):
|
|
"""Temporarily point `check_repo` at a temporary transformers source tree."""
|
|
old_path = check_repo.PATH_TO_TRANSFORMERS
|
|
check_repo.PATH_TO_TRANSFORMERS = str(path)
|
|
try:
|
|
yield
|
|
finally:
|
|
check_repo.PATH_TO_TRANSFORMERS = old_path
|
|
|
|
|
|
class CheckRepoTest(unittest.TestCase):
|
|
def setUp(self):
|
|
"""Reset the `get_model_modules` cache before each test."""
|
|
check_repo.get_model_modules.cache_clear()
|
|
self.addCleanup(check_repo.get_model_modules.cache_clear)
|
|
|
|
def _write_modeling_file(self, root: Path, model_name: str, content: str) -> None:
|
|
"""Create a temporary `modeling_*.py` file used by `check_models_have_kwargs`."""
|
|
model_dir = root / "src" / "transformers" / "models" / model_name
|
|
model_dir.mkdir(parents=True, exist_ok=True)
|
|
(model_dir / f"modeling_{model_name}.py").write_text(content, encoding="utf-8")
|
|
|
|
def test_get_model_modules_is_cached(self):
|
|
"""Repeated calls should reuse the cached module list instead of traversing models twice."""
|
|
alpha_modeling = object()
|
|
alpha_module = RecordingNamespace({"modeling_alpha": alpha_modeling, "configuration_alpha": object()})
|
|
fake_models = RecordingNamespace({"alpha": alpha_module, "deprecated_alpha": object()})
|
|
fake_transformers = SimpleNamespace(models=fake_models)
|
|
|
|
with patch.object(check_repo, "transformers", fake_transformers):
|
|
first = check_repo.get_model_modules()
|
|
second = check_repo.get_model_modules()
|
|
|
|
self.assertIs(first, second)
|
|
self.assertEqual(first, [alpha_modeling])
|
|
self.assertEqual(fake_models.dir_calls, 1)
|
|
self.assertEqual(fake_models.getattr_calls, ["alpha"])
|
|
self.assertEqual(alpha_module.dir_calls, 1)
|
|
self.assertEqual(alpha_module.getattr_calls, ["modeling_alpha"])
|
|
|
|
def test_check_models_have_kwargs_ignores_nested_classes(self):
|
|
"""Nested helper classes should not trigger missing-`**kwargs` failures."""
|
|
with tempfile.TemporaryDirectory() as tmpdir:
|
|
root = Path(tmpdir)
|
|
self._write_modeling_file(
|
|
root,
|
|
"foo",
|
|
"""
|
|
class PreTrainedModel:
|
|
pass
|
|
|
|
|
|
class FooModel(PreTrainedModel):
|
|
def forward(self, hidden_states, **kwargs):
|
|
return hidden_states
|
|
|
|
|
|
class HelperContainer:
|
|
class NestedModel(PreTrainedModel):
|
|
def forward(self, hidden_states):
|
|
return hidden_states
|
|
""".strip()
|
|
+ "\n",
|
|
)
|
|
|
|
with patch_transformers_path(root / "src" / "transformers"):
|
|
check_repo.check_models_have_kwargs()
|
|
|
|
def test_check_models_have_kwargs_still_checks_top_level_models(self):
|
|
"""Top-level model classes should still fail when `forward()` omits `**kwargs`."""
|
|
with tempfile.TemporaryDirectory() as tmpdir:
|
|
root = Path(tmpdir)
|
|
self._write_modeling_file(
|
|
root,
|
|
"foo",
|
|
"""
|
|
class PreTrainedModel:
|
|
pass
|
|
|
|
|
|
class FooModel(PreTrainedModel):
|
|
def forward(self, hidden_states):
|
|
return hidden_states
|
|
|
|
|
|
def make_nested_model():
|
|
class NestedModel(PreTrainedModel):
|
|
def forward(self, hidden_states, **kwargs):
|
|
return hidden_states
|
|
|
|
return NestedModel
|
|
""".strip()
|
|
+ "\n",
|
|
)
|
|
|
|
with patch_transformers_path(root / "src" / "transformers"):
|
|
with self.assertRaisesRegex(Exception, "FooModel"):
|
|
check_repo.check_models_have_kwargs()
|